[codex] Restore terminal coverage env test state after #1917 - #1918
Merged
Conversation
Contributor
Automated Status SummaryHead SHA: f90dd45
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR follows up on #1917 by hardening test isolation around environment variables used for terminal disposition coverage, preventing cross-test leakage when Node tests run under caller-provided env vars.
Changes:
- Restore both
UNSUPPORTED_VERIFIER_MODELSandTERMINAL_DISPOSITION_UNSUPPORTED_CODEX_MODELSafter the env-alias coverage test in the Node test suite. - Add a Python unit test ensuring parse-error overflow compaction does not preserve the incoming detail’s identity fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/scripts/test_aggregate_agent_metrics.py |
Adds regression test for parse-error overflow behavior and contract aggregation. |
.github/scripts/__tests__/terminal-disposition-coverage.test.js |
Prevents env var leakage by snapshotting and restoring relevant env vars in finally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to campaign issue #1836
Summary
Verification
Automated Status Summary
Scope
Sync/Dependabot Campaign Queue
Remote GitHub Actions owns discovery for sync-generated and Dependabot PR rounds. Local Codex should only claim items from this issue when
needs-local-codexwork is queued.Summary
Context for Agent
Related Issues/PRs
Tasks
Acceptance criteria
stranske/Workflowsand opened PR: fix: address sync review feedback for verify followups #1911 Addressed all 3 active review threads from `stranske/Travel-Pla...Head SHA: 63160cf
Latest Runs: ✅ success — Gate
Required: gate: ✅ success